Go to Page... |
Updated: | 02-02-13 06:08 PM |
Created: | 02-21-12 11:22 PM |
Downloads: | 5,154 |
Favorites: | 11 |
MD5: |
File Name |
Version |
Size |
Author |
Date |
1.11 |
11kB |
Montage |
01-20-13 11:58 AM |
|
1.10 |
187kB |
Montage |
12-18-12 11:27 PM |
|
1.8 |
159kB |
Montage |
07-01-12 03:25 PM |
|
1.7.1 |
124kB |
Montage |
04-28-12 11:52 AM |
|
1.7.1 |
124kB |
Montage |
04-23-12 07:32 PM |
|
1.7 |
124kB |
Montage |
04-20-12 07:12 PM |
|
1.6.3 |
120kB |
Montage |
03-27-12 05:38 PM |
|
1.6.2 Beta |
10kB |
Montage |
03-09-12 01:38 PM |
|
1.6.1 Beta |
9kB |
Montage |
03-07-12 04:27 PM |
|
1.6 Beta |
8kB |
Montage |
03-05-12 07:15 PM |
|
1.5 Beta |
7kB |
Montage |
02-29-12 06:50 PM |
|
1.4 Beta |
7kB |
Montage |
02-28-12 06:04 PM |
|
1.3 Beta |
7kB |
Montage |
02-24-12 11:12 AM |
|
1.2 Beta |
6kB |
Montage |
02-22-12 11:16 PM |
|
1.1 Beta |
6kB |
Montage |
02-22-12 06:59 PM |
|
1.0 Beta |
6kB |
Montage |
02-21-12 11:40 PM |
Comment Options |
02-29-12, 03:02 AM | |
|
I'm working on reworking a bit of stuff in your latest version to make it cleaner/etc. Once again, I hope you don't mind. Just trying to help out.
- I'm reimplementing the movement on drag. - I'm redoing the way configs work. Configs will now be more integrated with the code. You won't need to save/load anything. You just use the config variables. - I'll do what I can to lower the amount of global variables. - I am combining the six vertical/horizontal bar functions into three, wherein they take the orientation as an argument. - The fix you did for the text/icon alignment is a step in the right direction, but I believe that just completely 'reloading' everything will make more sure that nothing is out of place. Pretty much what I had in my previous code snippit. I'll be reimplementing this. - Changing height default from 1750 to 1000, as no monitor goes to 1750 height (ex. 1920x1080 resolution - 1920 width, 1080 height). - I'm going to take a look at the newly heavily messy SetText function to see if I can clean it up and slim it down at all. No promises. - Going to change around the way the slash handler works with arguments a little bit, to allow for an unlimited number of arguments without having to add more variables. I'm more than half way done right now. Will post the code here when I'm done. Update: Done. I did a lot. The majority of what I was doing was making your code cleaner and easier to work with. I also fixed up a couple noticeable and not so noticeable bugs. Money.lua Code: http://pastebin.com/Xkw4kY8i Changes: Soo many... please look at the code. - Using less globals - Configs no longer need to be loaded/saved; it's all done as the addon runs. - I redid a LOT of your vertical alignment functionality. I combined most vertical/horizontal seperations as best I could. - I redid the vertical UI. This was done a bit towards my bias, so I apologize. The text is no longer one character per line. So if you have 400 currency, it shows from left to right - like the horizontal orientation. The width was changed from 15 to 75 to accomodate for this change. - Drag the UI via /moneybar move - I realigned the icons so they are all the same amount apart. - When changing orientation, it changes x or y to 10. Apparently, if it tries to load stuff when part of the UI is out of view, it glitches a bit. I didn't fix this, but this change should help a lot with this issue. People just have to make sure it doesn't go out of view when 'reloading'. - I put all the functions in MoneyBar.FUNCTION NAME. This helps contain your code/variables and thus keep conflicts with other addons out. - SlashHandler now supports unlimited arguments and specific checking of how many arguments were sent by the user. cmd[0] is first argument[main command], cmd[1] is second argument, etc. In comparison to your old code, arg is cmd[0], a is cmd[1], b is cmd[2], etc. - Organized the loading code a bit - this goes hand and hand with the vertical alignment function changes. - On top of the previous config change, to make sure that there are always configs, default configs are set as the configs if the user has none set. See local defaultSave. - Added maximum and minimum amounts for /moneybar scale. Anything outside of these boundaries has been tested to ... not work/align well. This modification should be removed/modified when/if filtering specific currencies is added. I hope that this helps you out a bit. And I apologize for any mistakes, I coded most of this after 11:00 PM. It's 5 minutes till 4AM here, heh. Good luck Montage.
Last edited by TimeBomb : 02-29-12 at 05:56 AM.
|
|
TimeBomb |
View Public Profile |
Send a private message to TimeBomb |
Find More Posts by TimeBomb |
Add TimeBomb to Your Buddy List |
Montage |
View Public Profile |
Send a private message to Montage |
Find More Posts by Montage |
Add Montage to Your Buddy List |
TimeBomb |
View Public Profile |
Send a private message to TimeBomb |
Find More Posts by TimeBomb |
Add TimeBomb to Your Buddy List |
Montage |
View Public Profile |
Send a private message to Montage |
Find More Posts by Montage |
Add Montage to Your Buddy List |
03-05-12, 08:18 PM | |
|
I just want to go on record to apologize how the filter menu currently is. I will make it look less...thrown together when I can!
|
|
Montage |
View Public Profile |
Send a private message to Montage |
Find More Posts by Montage |
Add Montage to Your Buddy List |
03-05-12, 08:44 PM | ||
|
Quote:
Obviously the UI as an entirety needs a bit of cleaning up, but I'd also like to suggest: - Remembering the current set filters every time you open the filter UI. If I'm only showing 5, I want everything else to be red right when I open the filter UI. - A cancel button on the filter UI window (to close it without saving changes). - Optional/lower priority, but I would prefer that, instead of spreading them out to fit the whole bar, it spaces them out just like it does by default, thus leaving the bar with some possible empty space (which will go bye bye if people rescale the bar after applying filters). Bug report: - Pressing okay without deselecting any currency causes the array to be empty (when telling me "Showing only the following:"), and thus no currencies are shown. Overall, great job . |
|
|
TimeBomb |
View Public Profile |
Send a private message to TimeBomb |
Find More Posts by TimeBomb |
Add TimeBomb to Your Buddy List |
03-05-12, 08:47 PM | |||
|
Quote:
|
||
|
Montage |
View Public Profile |
Send a private message to Montage |
Find More Posts by Montage |
Add Montage to Your Buddy List |
03-06-12, 06:17 AM | |
Forum posts: 0
File comments: 20
Uploads: 0
|
please add lang file, i add russian lang
Now i translate in file, and addon full work with russian) |
|
gwynnbleiidd |
View Public Profile |
Send a private message to gwynnbleiidd |
Find More Posts by gwynnbleiidd |
Add gwynnbleiidd to Your Buddy List |
03-06-12, 10:28 AM | ||
|
Quote:
|
|
|
Montage |
View Public Profile |
Send a private message to Montage |
Find More Posts by Montage |
Add Montage to Your Buddy List |
03-06-12, 01:14 PM | |
Forum posts: 0
File comments: 20
Uploads: 0
|
These commands can be translated, I would just file derived variables and the field for the translation.
An example of how it is done in nkadvisor. By the way, another question, the basic position of the band at the bottom, I placed it on top. But when he is rejoining the basement forever with the screen. This is a fix or a permanent hands to prescribe? |
|
gwynnbleiidd |
View Public Profile |
Send a private message to gwynnbleiidd |
Find More Posts by gwynnbleiidd |
Add gwynnbleiidd to Your Buddy List |
03-06-12, 02:18 PM | ||
|
Quote:
It shouldn't be moving back to the bottom of the screen as the variables are saved when it's moved. I'll look into it and see what I can find. |
|
|
Montage |
View Public Profile |
Send a private message to Montage |
Find More Posts by Montage |
Add Montage to Your Buddy List |
03-07-12, 04:34 PM | |
|
I apologize for not removing all of my test code, new code is up that doesn't spew tables of currency information at you.
|
|
Montage |
View Public Profile |
Send a private message to Montage |
Find More Posts by Montage |
Add Montage to Your Buddy List |
03-07-12, 09:25 PM | |
|
Uhh... did I have debug code in a pastebin that I forgot to remove? If so, then g'damn, I apologize dearly.
|
|
TimeBomb |
View Public Profile |
Send a private message to TimeBomb |
Find More Posts by TimeBomb |
Add TimeBomb to Your Buddy List |
03-07-12, 10:26 PM | ||
|
Quote:
Also is anyone else experiencing text drift if they have the bar moved away from the left side of the screen? If I move the bar away from the left side of the screen and reload the UI the text moves that distance away from the icon. I cannot see why it's doing it! |
|
|
Montage |
View Public Profile |
Send a private message to Montage |
Find More Posts by Montage |
Add Montage to Your Buddy List |
03-08-12, 06:29 AM | |
Forum posts: 0
File comments: 20
Uploads: 0
|
I saw in the update that the variables are derived, but if I will make changes, then the addon will be appropriately only in Russian.
Or language support you put on the next update? |
|
gwynnbleiidd |
View Public Profile |
Send a private message to gwynnbleiidd |
Find More Posts by gwynnbleiidd |
Add gwynnbleiidd to Your Buddy List |